-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added "Simon Game Challenge" under Mood-Boosting Games #172
Conversation
@Amna-Hassan04 Now, I've raised my PR #172 and resolved the issue #80 , looking forward to getting it merged, please add all the necessary labels(GSSOC-EXT, Hacktoberfest and the level). |
@Amna-Hassan04 any update on this? @sanjay-kv please look into this, if possible try connecting with her. Only few days are left now. Thank you |
@Amna-Hassan04 I've raised my PR #172 and resolved the issue #80. Please merge my PR. Looking forward to your response. |
@sanyadureja I cant merge on some one else repo, you need tag admin or mentors. |
I've tagged @Amna-Hassan04 and am waiting for her response. |
@sanyadureja isnt this game the same one that had some bugs, have you solved the bugs? plz link it so i can test it. |
@Amna-Hassan04 there aren't any bugs in the game now, I've added the instructions as shown in the table above under the Simon game challenge heading along with the button. Game is working fine, please have a look at the video above. https://sanyadureja.github.io/Simon-Game-JavaScript-jQuery/ by clicking on the game button given in the video user will be taken to this link where they can play the game. |
@Amna-Hassan04 Check the video here of the changes in my PR. |
@sanyadureja I dont know why every time i try to do like the second level or the second step it always fails even when I do it right, i might be doing it wrong so maybe make a video of the gameplay in action bcz its not working well for me. plz take a look at it. The above video that you have attached is fine. I want to confirm that the gameplay actually works. |
Alright I'm sharing the video of the game play here. |
@Amna-Hassan04 Check the game play video, it's working fine. Screen.Recording.2024-10-28.at.9.47.28.PM.movIs my PR ready to merge now? |
@Amna-Hassan04 any update on this? |
@sanyadureja yes i guess this is ready to be merged plz make sure you update the pr to use the latest version of the project so i can merge. |
@sanyadureja just a recommendation here that in the game page maybe write a simple instructions or two for new users bcz it is confusing that we have to do the previous pattern and the new one too. even as a game dev my self I struggled to play it bcz their were no instructions. you can implement this later though I will merge your pr when you can confirm your using the latest version of the project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to work, the linked game does need polishing though such as atleast instructions as to how to play the game.
Latest version is already there. |
Alright I will implement it later for sure, thanks for the suggestions, maybe will raise a new PR. However, I have given instructions in the table for now. |
@Amna-Hassan04 I think atleast level 2 should be assigned, level 1 is really a small change. Requesting you to please think about it and let me now. Thank you. |
Embedding the game using i-frame is facing some issues due to Streamlit's limitations thus I've come with this approach.
I've made a new function for simon_game_challenge() and added a new button "Simon Game Challenge" below Start Mini Games under Mood-Boosting Games.
The Simon Game Challenge opens a table with the game's description, instructions and button to play.
Please have a look at the video, give your meaningful suggestions.
simon_game.mp4